perf: reduce allocation churn in operator serialization#31
Merged
Mythie merged 3 commits intoLibPDF-js:mainfrom Feb 19, 2026
Merged
perf: reduce allocation churn in operator serialization#31Mythie merged 3 commits intoLibPDF-js:mainfrom
Mythie merged 3 commits intoLibPDF-js:mainfrom
Conversation
Contributor
|
@ntedvs is attempting to deploy a commit to the mythie's projects Team on Vercel. A member of the Team first needs to authorize it. |
Mythie
approved these changes
Feb 19, 2026
Contributor
|
Great work! I had similar changes on a branch but never got back to it 🙌🏻 |
Contributor
Author
|
Thank you! Any tips for contributing going forward? |
Contributor
Author
|
@Mythie ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each
Operator.toBytes()call created ~10+ intermediateUint8Arrayallocations (one per operand, one per space separator, one concat result). ThenserializeOperators()did the same pattern again at a higher level with newlines. For 100 rectangles, that's ~7,600 throwaway allocations per iteration.Added
Operator.writeTo(writer: ByteWriter)so operators write directly into a shared buffer instead of building intermediate arrays. RewroteserializeOperators()to use a singleByteWriterinstead of collecting per-operator byte arrays and concatenating.Also removed
byteLength()(dead code, zero production callers).Numbers
Drawing benchmarks (absolute throughput):
Comparison against pdf-lib (draw 50 rectangles):
Test plan