fix(api): resolve indirect refs in resource subdictionaries#32
Merged
Conversation
addXObjectResource and registerResource called resources.get() without a resolver, so when a resource subdictionary (e.g. /XObject) was stored as an indirect PdfRef, it failed the instanceof PdfDict check and silently replaced the existing dict with an empty one. This dropped all pre-existing resource entries. Scanner-produced PDFs (e.g. Konica Minolta) commonly store /Resources /XObject as an indirect object, so embedPage + drawPage on those PDFs would erase the original page content entirely. addFontResource already passed the resolver correctly; this aligns the other two methods to match.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Benchmark ResultsComparisonLoad PDF
Create blank PDF
Add 10 pages
Draw 50 rectangles
Load and save PDF
Load, modify, and save PDF
Extract single page from 100-page PDF
Split 100-page PDF into single-page PDFs
Split 2000-page PDF into single-page PDFs (0.9MB)
Copy 10 pages between documents
Merge 2 x 100-page PDFs
CopyingCopy pages between documents
Duplicate pages within same document
Merge PDFs
Drawingbenchmarks/drawing.bench.ts
Formsbenchmarks/forms.bench.ts
Loadingbenchmarks/loading.bench.ts
Savingbenchmarks/saving.bench.ts
SplittingExtract single page
Split into single-page PDFs
Batch page extraction
Environment
Results are machine-dependent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addXObjectResource and registerResource called resources.get()
without a resolver, so when a resource subdictionary (e.g. /XObject)
was stored as an indirect PdfRef, it failed the instanceof PdfDict
check and silently replaced the existing dict with an empty one.
This dropped all pre-existing resource entries. Scanner-produced PDFs
(e.g. Konica Minolta) commonly store /Resources /XObject as an
indirect object, so embedPage + drawPage on those PDFs would erase
the original page content entirely.
addFontResource already passed the resolver correctly; this aligns
the other two methods to match.