perf(parser): fast-path name tokenization to avoid TextDecoder#33
Merged
Mythie merged 1 commit intoLibPDF-js:mainfrom Feb 22, 2026
Merged
Conversation
Skip intermediate number[] array, Uint8Array allocation, and TextDecoder.decode() for the 99%+ of PDF names that contain no #XX hex escapes. Build string directly via String.fromCharCode loop. 5-10% improvement on parsing benchmarks (CPU profile showed readName + TextDecoder.decode at ~20% of total parse time).
Contributor
|
@ntedvs is attempting to deploy a commit to the mythie's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readName()that avoidsnumber[]accumulation,Uint8Arrayallocation, andTextDecoder.decode()for names without#XXhex escapes (99%+ of cases)String.fromCharCodeloop#escapes are presentBenchmarks (5-run average)
Motivation
CPU profiling showed
readName+TextDecoder.decodeconsuming ~20% of total parse time. PDF name tokens (/Type,/Page,/MediaBox) are overwhelmingly pure ASCII with no hex escapes.Test plan