Minor optimization for SSLObject.read call#725
Closed
tarasko wants to merge 2 commits intoMagicStack:masterfrom
Closed
Minor optimization for SSLObject.read call#725tarasko wants to merge 2 commits intoMagicStack:masterfrom
tarasko wants to merge 2 commits intoMagicStack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at perf output I noticed that a new Long object was constructed before we call SSLObject.read
Indeed, Cython generates code to make a python object, because SSL_READ_MAX_SIZE is a constant of primitive type.
Since the value is big, it is not cached by Python, and a new object is constructed every time.