Align definePackage behavior with JRE modular classloaders#64
Open
shartte wants to merge 1 commit intoMcModLauncher:mainfrom
Open
Align definePackage behavior with JRE modular classloaders#64shartte wants to merge 1 commit intoMcModLauncher:mainfrom
shartte wants to merge 1 commit intoMcModLauncher:mainfrom
Conversation
shartte
force-pushed
the
remove-define-package
branch
from
9c401a5 to
464b664
Compare
Su5eD
approved these changes
Mar 30, 2024
Member
|
Do we know why this is discouraged by the JDK? |
Contributor
Author
Nope. Probably because they define the package implicitly anyway in modular loaders. p.s.: A side-effect is that the fix to load package-info is no longer needed since it'll be implicitly loaded by the package definition that results from defining a class in that package (fun!) |
Member
|
Was the use of the package in fabric mixin fixed? |
Contributor
Author
|
Fabric Mixin released a new version that contains this change: |
Matyrobbrt
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an obvious breaking change
SJH will currently "manually" definePackage every package it comes across. The revised Javadoc for definePackage says this is discouraged, and the JRE itself does not do this.
This leads to a discrepancy between SJH and platform modular loaders which prevents us from using them, currently. (As a consequence we cannot put FML or ML directly onto the JRE module path).
A version of SJH with this change will no longer return the implementation version and specification version of packages, and calls to
Package#isCompatibleWithwill not work.