Skip to content

Comments

Fixed android predictive text input#4342

Open
gabriel-bolbotina wants to merge 2 commits intomasterfrom
fix/android-unconfirmed-text
Open

Fixed android predictive text input#4342
gabriel-bolbotina wants to merge 2 commits intomasterfrom
fix/android-unconfirmed-text

Conversation

@gabriel-bolbotina
Copy link
Contributor

Fixed android predictive text input that was waiting for confirmation, by checking if preeditText changed and if it did, then committing the input.

Tested on Android with the following keyboards:

  • swiftKey
  • gboard
  • samsung keyboard
Screen_Recording_20260220_132639.mp4

Also tested on iOS, where it previously worked.

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Pull Request Test Coverage Report for Build 22303413876

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 104 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.09%) to 59.799%

Files with Coverage Reduction New Missed Lines %
mm/app/attributes/attributecontroller.cpp 1 76.83%
mm/core/merginuserauth.cpp 9 68.24%
mm/core/merginapi.cpp 13 75.07%
mm/app/variablesmanager.cpp 36 25.93%
mm/app/position/positionkit.cpp 45 68.38%
Totals Coverage Status
Change from base Build 22183088107: -0.09%
Covered Lines: 8757
Relevant Lines: 14644

💛 - Coveralls

@github-actions
Copy link

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 63831 dmg Expires: 21/05/2026 #6383
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 55781 win64 Expires: 21/05/2026 #5578
Android Build 📬 Mergin Maps 769351 APK [arm64-v8a] Expires: 21/05/2026 #7693
Android Build 📬 Mergin Maps 769311 APK [armeabi-v7a] Expires: 21/05/2026 #7693
iOS Build 📭 Build not yet complete or failed.

Enhanced search to trim the last whitespace of user's input
@Withalion Withalion linked an issue Feb 23, 2026 that may be closed by this pull request
@github-actions
Copy link

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📭 Build not yet complete or failed.
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 55901 win64 Expires: 24/05/2026 #5590
Android Build 📬 Mergin Maps 770551 APK [arm64-v8a] Expires: 24/05/2026 #7705
Android Build 📬 Mergin Maps 770511 APK [armeabi-v7a] Expires: 24/05/2026 #7705
iOS Build 📭 Build not yet complete or failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the app react to unconfirmed text

2 participants