added bash script to automate jules kgo process.#104
Draft
cameronbateman-mo wants to merge 2 commits intomainfrom
Draft
added bash script to automate jules kgo process.#104cameronbateman-mo wants to merge 2 commits intomainfrom
cameronbateman-mo wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
|
TODO: Future proof by separating out ex into variables |
Contributor
ericaneininger
left a comment
There was a problem hiding this comment.
General comments while this PR is still in draft...
- This script could do with some future proofing. It WILL be run on machines other than EX and potentially other than AzureSpice
- Keep absolute paths out as far as possible – they will probably change
- Keep machine specific stuff together as far as possible
- Stick to generic variable names if possible
- The final exit (in particular) is unnecessary and may well cause the user's shell to close (irritating). I assume this is here because the original script xsudo'ed as julesadmin and then exited as that user.
- Nested "" are best avoided as they are confusing to read. An alternative way to delimit environment variables would be
${VARNAME}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automate jules kgo process found here: https://code.metoffice.gov.uk/trac/jules/wiki/KGOInstall
Script copies from user directories on azure spice and ex machines to the kgo locations on those machines.
Have tested with dummy directories in the appropriate places but would be a good idea to test with an actual install to ensure it has the intended behaviour.
Checklist