fix(ci): decouple prepare job from action-checkout-and-setup#8054
Draft
cryptodev-2s wants to merge 1 commit intomainfrom
Draft
fix(ci): decouple prepare job from action-checkout-and-setup#8054cryptodev-2s wants to merge 1 commit intomainfrom
cryptodev-2s wants to merge 1 commit intomainfrom
Conversation
Replace the composite action with a plain checkout + corepack enable. The prepare job only lists workspace package names, so it doesn't need caching, yarn install, or multiple Node versions. This makes it faster, simpler, and resilient to upstream action changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The upgrade to
action-checkout-and-setupfrom v2 to v3 (#8047) broke thepreparejob. v3 skips the git checkout on cache hits, causingyarn workspaces listto produce empty output, which makesfromJsonfail with "empty input".This PR takes the long-term approach: replace the composite action entirely with a plain
actions/checkout+corepack enable. Thepreparejob only lists workspace package names — it doesn't need caching,yarn install, multiple Node versions, orsetup-node. This makes it:action-checkout-and-setup(v4, v5, etc.) can't break it againSee #8053 for the minimal quick-fix alternative.
References
Checklist
Note
Low Risk
Low risk workflow-only change that simplifies the
preparejob, but CI could fail ifcorepack/yarn/jqaren’t available or if checkout behavior differs from the composite action.Overview
Fixes CI flakiness in
lint-build-test.ymlby decoupling thepreparejob fromMetaMask/action-checkout-and-setup@v3, which could skip checkout on cache hits.preparenow just runsactions/checkout@v5+corepack enablebefore computingchild-workspace-package-namesviayarn workspaces list, removing the prior Node-version matrix and caching/setup complexity for this job.Written by Cursor Bugbot for commit 4314635. This will update automatically on new commits. Configure here.