Skip to content

fix(ci): decouple prepare job from action-checkout-and-setup#8054

Draft
cryptodev-2s wants to merge 1 commit intomainfrom
fix/prepare-job-lightweight
Draft

fix(ci): decouple prepare job from action-checkout-and-setup#8054
cryptodev-2s wants to merge 1 commit intomainfrom
fix/prepare-job-lightweight

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 26, 2026

Explanation

The upgrade to action-checkout-and-setup from v2 to v3 (#8047) broke the prepare job. v3 skips the git checkout on cache hits, causing yarn workspaces list to produce empty output, which makes fromJson fail with "empty input".

This PR takes the long-term approach: replace the composite action entirely with a plain actions/checkout + corepack enable. The prepare job only lists workspace package names — it doesn't need caching, yarn install, multiple Node versions, or setup-node. This makes it:

  • Faster — no dependency installation, runs in seconds
  • Simpler — 2 setup steps instead of a heavy composite action
  • Resilient — future changes to action-checkout-and-setup (v4, v5, etc.) can't break it again

See #8053 for the minimal quick-fix alternative.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk workflow-only change that simplifies the prepare job, but CI could fail if corepack/yarn/jq aren’t available or if checkout behavior differs from the composite action.

Overview
Fixes CI flakiness in lint-build-test.yml by decoupling the prepare job from MetaMask/action-checkout-and-setup@v3, which could skip checkout on cache hits.

prepare now just runs actions/checkout@v5 + corepack enable before computing child-workspace-package-names via yarn workspaces list, removing the prior Node-version matrix and caching/setup complexity for this job.

Written by Cursor Bugbot for commit 4314635. This will update automatically on new commits. Configure here.

Replace the composite action with a plain checkout + corepack enable.
The prepare job only lists workspace package names, so it doesn't need
caching, yarn install, or multiple Node versions. This makes it faster,
simpler, and resilient to upstream action changes.
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner February 26, 2026 17:31
@cryptodev-2s cryptodev-2s marked this pull request as draft February 26, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant