Conversation
|
jdrueckert
left a comment
There was a problem hiding this comment.
From looking at the code changes (and ignoring the ones duplicating #239), this looks reasonable. I'll need to test it, though, before merging. I'll try to find time to do that this weekend, not sure I will though, so apologies as it might take another week before I get to merge this.
Meanwhile please remove the unused var declaration in Blog.jsx and the changes duplicating your other PR.
|
|
||
| const codeBlockRegex = /```([\s\S]*?)```/g; | ||
|
|
There was a problem hiding this comment.
as you're not referencing codeBlockRegex anywhere, I assume this can be removed
|
@5archoufa I locally tested this and noticed two issues:
Also, prettier complains about some formatting issues. You can check the warnings out locally using |
|
I've made a pull request here: #244 |
Okay, then I'll close this one. But, just fyi, you don't need to open a new PR whenever you add changes. You can simply push to the same branch again and the PR should update. |




Include date in URL