Conversation
|
Preview Lambda: |
1 similar comment
|
Preview Lambda: |
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-55
branch
2 times, most recently
from
741bceb to
18a897d
Compare
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-95
branch
from
c7a8987 to
dc17f45
Compare
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Filesystem Scan SummaryFilesystem: /tmp/artifact
✅ No vulnerabilities found. |
nhsd-rebecca-flynn
left a comment
nhsd-rebecca-flynn
left a comment
There was a problem hiding this comment.
LGTM. A couple of minor suggestions.
bruno/PDM/README.md
Outdated
| ## Authentication Setup | ||
|
|
||
| Follow the instructions on this [confluence page](https://nhsd-confluence.digital.nhs.uk/x/ixnIT) to setup Bruno with the PDM INT Environment | ||
| Follow the instructions on this [confluence page](https://nhsd-confluence.digital.nhs.uk/x/ixnIT) to setup Bruno with the PDM INT Environment. Authentication can the be completed via the `Get Auth Token` call within the `APIM` collection. |
There was a problem hiding this comment.
can then be completed
There was a problem hiding this comment.
Well spotted, updated.
bruno/PDM/README.md
Outdated
| ## Getting Auth Token | ||
|
|
||
| Once you have completed the previous instructions you should be able to run the Get Auth Token request, once the request is complete it should copy the returned token into the `auth_token` environment variable. The collection has been setup to automatically use this variable to authenticate requests | ||
| Once the request is complete it should copy the returned token into the `auth_token` global environment variable. The collection has been setup to automatically use this variable to authenticate requests |
There was a problem hiding this comment.
Once the Get Auth Token request
There was a problem hiding this comment.
Updated
bruno/PDM/environments/PDM.bru
Outdated
| JWT_SECRET, | ||
| auth_token | ||
| ] | ||
| vars { |
There was a problem hiding this comment.
Can this file now be deleted if we have stripped everything from it?
There was a problem hiding this comment.
Yup I think so, removed this file now.
nhsd-jack-wainwright
dismissed
nhsd-rebecca-flynn’s stale review
via
081d0ab
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-95
branch
from
431411f to
081d0ab
Compare
|
…cluded initial validation
nhsd-jack-wainwright
force-pushed
the
feature/CDAPI-95
branch
from
081d0ab to
fbe99ab
Compare
|
Deployment Complete
|
2 participants
Description
Adding additional validation logic to the Bundle endpoint.
Context
Begins to add required validation to the existing initial Bundle endpoint.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.