[NDR-375] Author & custodian should be optional return fields. #1077
Open
jameslinnell wants to merge 8 commits intomainfrom
Open
[NDR-375] Author & custodian should be optional return fields. #1077jameslinnell wants to merge 8 commits intomainfrom
jameslinnell wants to merge 8 commits intomainfrom
Conversation
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
force-pushed
the
NDR-375
branch
from
5add8b5 to
30ed4e5
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
force-pushed
the
NDR-375
branch
from
123fc9f to
ed4d937
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
force-pushed
the
NDR-375
branch
from
ed4d937 to
80085b1
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
force-pushed
the
NDR-375
branch
from
ae48246 to
8f7b2c6
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
force-pushed
the
NDR-375
branch
from
636b2a4 to
2068a61
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
| author_ods = document.author or self.custodian | ||
| custodian_ods = document.custodian or self.custodian | ||
| else: | ||
| if document.author: |
Contributor
There was a problem hiding this comment.
Could this be refactored to be just
author_ods = document.author or None
custodian_ods = document.custodian or None
Then don't need setting on line 246 & 247, and restricts it to our snomed logic only
jameslinnell
force-pushed
the
NDR-375
branch
from
2068a61 to
36adae1
Compare
jameslinnell
temporarily deployed
to
development
GitHub Actions
Inactive
Code security issues foundView full details here. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: NDR-375
Description
Context
Checklist
Tasks for all changes:
Deploy - Sandbox- workflow run - TBCSANDBOX Full- Deploy feature branch to sandbox- workflow run - TBC