Open
Conversation
marcschier
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request introduces a client lockout mechanism to the OPC UA server to protect against brute-force authentication attempts. After a configurable number of failed authentication attempts, clients are temporarily locked out from further attempts. The implementation includes tracking failed attempts, enforcing lockout periods, and resetting counters after successful authentication. Comprehensive integration tests are also added to verify the new behavior.
Client Lockout Mechanism Implementation
SessionManagerto track failed authentication attempts per client using a newClientLockoutInfoclass and aConcurrentDictionary. Clients are identified by certificate thumbprint, application URI, or secure channel ID. [1] [2]CreateSessionAsync: clients exceeding the allowed number of failures are denied access for a set duration, with warnings logged and informative error messages returned. Lockout state is checked and updated on each authentication attempt. [1] [2] [3] [4]Related Issues
Types of changes
Checklist
Further comments
The spec is not 100% accurate what to do, one sections says you shall lock out the client, one other suggest to delay responses instead.