Connection Name was added a while ago, these templates weren't update…

[twerthi]

---

Background

The cmdlets that these templates use, SimplySql, was updated quite some time ago to include a named connection parameter. These templates were not updated to make use of it, the finally would attempt to close a closed connection and fail obscuring the actual error. The cfreate user template was completely broken, the connection string section wasn't populating resulting in a connection string without any of the parameters substituted.

Results

Templates have been updated, finally statement updated to test for open connection before trying to close.

Before

If templates encountered an error, the finally statement woudl attempt to close a closed connection and fail, hiding the originating error.

After

finally tests for a closed connection first so it doesn't hide the error

Pre-requisites

• Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
  • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
• Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
• Parameter names should not start with $
• Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
• LastModifiedBy field must be present, and (optionally) updated with the correct author
• The best practices documented here have been applied
• If a new Category has been created:
  • An image with the name {categoryname}.png must be present under the step-templates/logos folder
  • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes errors I found.

[github-actions]

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

[harrisonmeister]

LGTM

[harrisonmeister]

LGTM