oil-lib: alias oils for api compatability

[gauteh]

No description provided.

[knutfrode]

Did you duplicate an oil, so that there are two lines with identical data and ID's, but different names? Does that work in practice?

[gauteh]

Hm, yeah, have to change the ID as well! tor. 16. sep. 2021 kl. 10:55 skrev Knut-Frode Dagestad < ***@***.***>:

…

Did you duplicate an oil, so that there are two lines with identical data and ID's, but different names? Does that work in practice? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAN364S4CO3OSJVKP54NQLUCGWJ5ANCNFSM5EEHY72Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[knutfrode]

Sounds dangerous! Could be the start of the end of the world. As we know it.

[knutfrode]

Instead of fixing this in ADIOS, I could make a mapping in OpenOil: OldOilNames -> CorrespondingNewOilNames

[gauteh]

Yes, I am also doing this in the new version: https://github.com/OpenDrift/opendrift/pull/685/files#diff-bd0f1c9292901469fefb1fccf0f9d0b5e8a99e07c6d422218688032ea9c5e8dbR27 -- the main reason for not doing that now is:

• it will probably be a bigger change and need more tests
• the adios oil library is ours and is going to be discontinued anyway

otherwise: I agree it is a better solution !

-- gaute

[knutfrode]

Ok, so the mapping from GENERIC -> "some specific oil" will be in OpenOil, and not in ADIOS itself?

[gauteh]

Yes, and it will be easy to add our own new oils in opendrift, before they are included or updated upstream. tor. 16. sep. 2021 kl. 11:09 skrev Knut-Frode Dagestad ***@***.***>:

…

Ok, so the mapping from GENERIC -> "some specific oil" will be in OpenOil, and not in ADIOS itself? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.