Skip to content

Reorder npm diagnostic checks: project-specific before environment #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dermatz merged 2 commits into from
Feb 16, 2026
Merged

Reorder npm diagnostic checks: project-specific before environment #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dbf110
Initial plan
Copilot Feb 16, 2026
29a765a
Reorder diagnostic checks: package.json first, then npm/node
Copilot Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/Service/NodePackageManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,33 +149,33 @@ private function diagnoseAndReportNpmFailure(string $path, SymfonyStyle $io, \Ex
$io->error('Failed to install node modules.');
$io->newLine();

// Check 1: npm availability
// Check 1: package.json validity (project-specific, quick check)
if (!$this->isPackageJsonValid($path)) {
$io->error('package.json is missing or contains invalid JSON.');
$io->writeln('<fg=yellow>Fix:</>');
$sanitizedPath = preg_replace('/[[:cntrl:]]/', '', $path);
$io->writeln(
' Verify package.json exists at: ' . $sanitizedPath . '/package.json'
);
return;
}

// Check 2: npm availability
if (!$this->isCommandAvailable('npm')) {
$io->error('npm is not installed or not available in PATH.');
$io->writeln('<fg=yellow>Fix:</>');
$io->writeln(' Install Node.js and npm: https://nodejs.org/');
return;
}

// Check 2: node availability
// Check 3: node availability
if (!$this->isCommandAvailable('node')) {
$io->error('Node.js is not installed or not available in PATH.');
$io->writeln('<fg=yellow>Fix:</>');
$io->writeln(' Install Node.js: https://nodejs.org/');
return;
}

// Check 3: package.json validity
if (!$this->isPackageJsonValid($path)) {
$io->error('package.json is missing or contains invalid JSON.');
$io->writeln('<fg=yellow>Fix:</>');
$sanitizedPath = preg_replace('/[[:cntrl:]]/', '', $path);
$io->writeln(
' Verify package.json exists at: ' . $sanitizedPath . '/package.json'
);
return;
}

// Check 4: package-lock.json corruption
if ($this->fileDriver->isExists($path . '/package-lock.json')) {
if (!$this->isPackageLockValid($path)) {
Expand Down
Loading