refactor: replace which with direct command execution for cross-platform compatibility#141
Merged
dermatz merged 3 commits intofeature-magento-default-checksfrom Feb 16, 2026
Merged
Conversation
Co-authored-by: dermatz <6103201+dermatz@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor npm failure diagnostics based on review feedback
refactor: replace Feb 16, 2026
which with direct command execution for cross-platform compatibility
dermatz
approved these changes
Feb 16, 2026
dermatz
approved these changes
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the isCommandAvailable() method in NodePackageManager to improve cross-platform compatibility by replacing the Unix/Linux-specific which command with direct command execution using the --version flag.
Changes:
- Replaced
which <command>pattern with<command> --version 2>/dev/nullapproach - Aligns with existing cross-platform pattern consistently used in
CheckCommandmethods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isCommandAvailable()method inNodePackageManagerused the Unix/Linux-specificwhichcommand, causing failures on Windows systems.Changes
which <command>pattern with direct command execution using<command> --version 2>/dev/nullCheckCommand::getNodeVersion()andCheckCommand::getNpmVersion()Implementation
This approach works because both
npmandnodesupport the--versionflag, and the Shell service catches execution failures when commands don't exist.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.