Merged
Conversation
farski
requested changes
Feb 24, 2026
spire/templates/apps/augury.yml
Outdated
| HealthCheck: | ||
| Command: | ||
| - CMD-SHELL | ||
| - ./bin/docker-health-check |
Member
There was a problem hiding this comment.
There is some value in ensuring that this command always returns exactly 0 or 1. I've seen cases where other return values behave unexpectedly.
Member
Author
There was a problem hiding this comment.
Does it make sense to have that live inside the docker-health-check script?
Added: https://github.com/PRX/augury.prx.org/pull/1979/changes/2f68251e055d40c7bff159665e231e849ffd8cf7
Member
There was a problem hiding this comment.
I think enforcing it here ensures the result, even if the script changes down the road, but I have no strong preference. I think this is a good solution for now.
farski
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart to https://github.com/PRX/augury.prx.org/pull/1979