Fix issue with converted damage showing no poison stacks#8991
Open
wh98yap-hub wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix issue with converted damage showing no poison stacks#8991wh98yap-hub wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
wh98yap-hub wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
|
While to poison chance is now calculated correctly, I don't think it's working for Full DPS yet? Poison DPS doesn't appear when a skill is toggled for Full DPS, forcing 100% Chance to Poison in Custom Modifiers makes the calculation correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8990.
Description of the problem being solved:
Fixed poison stacks showing 0 despite 100% poison chance when using multi-step damage conversion chains (e.g., Cold→Fire→Chaos→Poison). The issue occurred because Path of Building's ailment calculations only considered unconverted damage portions and didn't account for damage that becomes eligible for ailments through conversion chains.
Root causes addressed:
calcAilmentSourceDamage()only used unconverted damage, ignoring conversion contributionsChaosPoisonChancefor both hit and crit scenariosCanPoisonflags for damage types that convert to ChaosSteps taken to verify a working solution:
Link to a build that showcases this PR:
Path of Building test build:
Before fix:
Poison DPS: 0, Poison Stacks: 0, despite showing 100% poison chance

After fix:
Poison DPS: 1,178.9, Poison Stacks: 0.67, Poison Chance: 100% (working correctly)

Technical Changes:
calcAilmentConversionMultiplier()function for multi-step conversion trackingcalcAilmentSourceDamage()to use conversion chains instead of just unconverted portionsCanPoison/CanIgniteflag enabling for converted damage typesChaosPoisonChancefor both hits and crits