Fixed KF DPS and attack speed breakpoint calcs#9452
Open
Bobastic wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Fixed KF DPS and attack speed breakpoint calcs#9452Bobastic wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Bobastic wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9424
Description of the problem being solved:
When comparing attack speed breakpoints for KF in PoB vs in game it is noticeable that PoB is wrong. For example, you can "gatling" in game holding right click when PoB tells you that you shouldn't be able to.
The issue is that PoB uses server ticks for KF attack speed breakpoint calcs where they apparently don't matter (see the video in #9424)
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/kKi1MvaNfdKG
Before screenshot:
After screenshot: