fix: clear caches after parameter updates in simulation modifier#212
Draft
nikhilwoodruff wants to merge 1 commit intomainfrom
Draft
fix: clear caches after parameter updates in simulation modifier#212nikhilwoodruff wants to merge 1 commit intomainfrom
nikhilwoodruff wants to merge 1 commit intomainfrom
Conversation
nikhilwoodruff
force-pushed
the
fix-parameter-cache-clearing
branch
2 times, most recently
from
a094b9a to
b46780b
Compare
The simulation modifier now clears both parameter caches and variable holder caches after updating parameter values. This ensures that subsequent calculations use the updated parameter values instead of stale cached values. Previously, when a simulation was created and then modified with parameter updates, the cached calculations would still use the old parameter values, causing reforms to have no effect.
nikhilwoodruff
force-pushed
the
fix-parameter-cache-clearing
branch
from
b46780b to
d5b6b4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where policy reforms applied via
simulation_modifier_from_parameter_valueshad no effect because the simulation was using cached values computed before the modifier ran.The modifier now clears:
tax_benefit_system.reset_parameter_caches()holder.delete_arrays()for all populationsTest plan
tests/test_parametric_reforms.pywhich verifies UC standard allowance changes take effectcalculate_household_impactfunction