feat: Add default_value and value_type to Variable class#228
Merged
anth-volk merged 4 commits intoapp-v2-migrationfrom Feb 16, 2026
Merged
feat: Add default_value and value_type to Variable class#228anth-volk merged 4 commits intoapp-v2-migrationfrom
anth-volk merged 4 commits intoapp-v2-migrationfrom
Conversation
- Add default_value (Any) and value_type (type) fields to Variable model - Update US and UK models to serialize default_value for JSON compatibility: - Enum values converted to their .name string - datetime.date values converted to ISO format string - Primitives (bool, int, float, str) kept as-is - value_type preserves the original type for downstream consumers Closes #226 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add tests verifying US age variable has default_value of 40 - Add tests verifying enum variables have string default_value - Add tests verifying variables have value_type set - Add tests verifying UK model variable default_value 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Converting to draft. Need to make modifications to simulation class for US. |
Allow PR checks to run for PRs targeting any branch, not just main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226
Summary
default_valueandvalue_typefields to theVariableclass in policyengine.pydefault_valuefor JSON compatibility:.namestring (e.g., "SINGLE")datetime.datevalues are converted to ISO format stringvalue_typepreserves the original type for downstream consumersTest plan
default_valuepopulated correctly🤖 Generated with Claude Code