Add support for all WoW client versions (TBC, WotLK, updated Vanilla/Retail)#39
Open
paradosi wants to merge 3 commits intoSharpWoW:mainfrom
Open
Add support for all WoW client versions (TBC, WotLK, updated Vanilla/Retail)#39paradosi wants to merge 3 commits intoSharpWoW:mainfrom
paradosi wants to merge 3 commits intoSharpWoW:mainfrom
Conversation
- Add Interface-BCC (20505) and Interface-Wrath (30405) to TOC - Update Interface to 110207, Interface-Vanilla to 11508 - Add C_AddOns shim for older clients without the namespace - Add IsGUIDInGroup fallback for Vanilla Classic - Add UnitIsTapDenied fallback for clients that don't have it - Add Settings API guards in Options.lua with fallback to legacy InterfaceOptions_AddCategory for Classic clients
- Add separate TOC files for each client flavor (TBC, Wrath, Vanilla, Cata) since Classic clients don't reliably use multi-interface single TOC - Bundle LibStub, CallbackHandler-1.0, and LibDBIcon-1.0 (CurseForge packager normally bundles these but manual installs need them) - Strip #@no-lib-strip@ tags so libs load in manual installs - Fix @Project-Version@ placeholder to v2.32.0
Added compatibility shim for Anniversary realm's Settings API. Falls back to old InterfaceOptions_AddCategory if available. Fixes error: attempt to call global 'InterfaceOptions_AddCategory' (a nil value) The Anniversary realm removed the old API and uses Settings.RegisterCanvasLayoutCategory instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for TBC Anniversary and WotLK Classic clients, updates existing interface versions, and adds compatibility shims so the addon works across all current WoW flavors.
Changes
TOC
Interface-BCC: 20505(TBC Anniversary Edition)Interface-Wrath: 30405(WotLK Classic)Interface: 110207(current Retail)Interface-Vanilla: 11508(current Classic Era)KillTrack.lua
C_AddOnsshim for older clients that don't have the namespace (falls back toGetAddOnMetadata/IsAddOnLoaded)IsGUIDInGroupfallback for Vanilla Classic (scans party/raid unit IDs)UnitIsTapDeniedfallback for clients that don't have itOptions.lua
SettingsAPI guards with fallback to legacyInterfaceOptions_AddCategoryandInterfaceOptionsFrame_OpenToCategoryfor Classic clients that don't have the modern Settings APIHideUIPanel(InterfaceOptionsFrame)for clients where it may not existTesting
if not X then) so existing Retail/Cata behavior is unchanged