Add warning and confirmation before running theme doctor#6832
Open
FKauwe wants to merge 3 commits intojf-audit-protofrom
Open
Add warning and confirmation before running theme doctor#6832FKauwe wants to merge 3 commits intojf-audit-protofrom
FKauwe wants to merge 3 commits intojf-audit-protofrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #1016
Building off the architecture for a new
theme doctorcommand in this PR, I introduce a warning and confirm with the user before executing thetheme doctortest suite, as the tests will interact with user's remote shop.WHAT is this pull request doing?
renderConfirmationPromptfunction to thedoctor/theme/index.tsfileUser ConfirmsandUser Cancelsare correctlooks like this when User Confirms(test suite executes):

and when User Cancels (exit the command):

How to test your changes?
pull my branch down locally
p buildrun
shopify-dev doctor theme -e <local-env-name>in external terminalsee the warning and prompt and the expected behaviors between Yes/No