Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that you need different publicPaths for different deployments. The solution is to use relative paths in the HTML and set publicPath: '':
Now with publicPath:'' and relative paths (./mashlib.js), the chunks will load relative to wherever the HTML file is:
✅ http://alice.localhost:3000/browse.html → loads ./mashlib.js and ./841.mashlib.js
✅ https://solidos.github.io/mashlib/dist/browse.html → loads ./mashlib.js and ./841.mashlib.js
Rebuild with npm run build and both scenarios should work!
With publicPath: '', HtmlWebpackPlugin will inject <script src="mashlib.min.js"></script> (relative path without the ./ prefix, which is equivalent).
The generated databrowser.html will have relative paths for all assets, just like browse.html now does. Both work the same way.With publicPath: '', HtmlWebpackPlugin will inject <script src="mashlib.min.js"></script> (relative path without the ./ prefix, which is equivalent).
The generated databrowser.html will have relative paths for all assets, just like browse.html now does. Both work the same way.
Claude Son