Add plotting functions for drift and diagnostics to KS4#4387
Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Added condition to skip diagnostic plots based on parameters.
for more information, see https://pre-commit.ci
alejoe91
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In KS4
4.0.33drift maps and other diagnostic plots were added as output. These lines are added here.More generally, I wonder if we can switch to just wrapping the kilosort entry function
run_kilosortrather than recreating the internals? A benefit is we wouldn't have to worry about the internal API, and would just need to track changes to this entry function signature. There are some functionality we would need them to ask adding to kilosort:I'm sure there is other stuff I'm overlooking though