Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR advances local dependencies and addresses recent API changes within the Spine Event Engine ecosystem. The update encompasses version bumps for core libraries, logging framework updates, and Kotlin/JUnit version upgrades.
- Updates Base and Logging library versions to incorporate recent API changes
- Bumps Kotlin from 2.1.20 to 2.1.21 and JUnit from 5.12.2 to 5.13.2
- Refactors configuration paths from
config/tobuildSrc/directory structure
Reviewed Changes
Copilot reviewed 103 out of 105 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Increments project version from 202 to 210 |
| src/test/kotlin/io/spine/testing/logging/mute/MuteLoggingExtensionSpec.kt | Updates Logger type parameter and method signatures for API compatibility |
| src/main/kotlin/io/spine/testing/logging/mute/Muting.kt | Adapts logging context API calls to new getInstance() pattern |
| src/main/java/io/spine/testing/Testing.java | Removes generic type parameter from Logger declaration |
| pom.xml | Updates dependency versions across Protobuf, Kotlin, JUnit, and Spine libraries |
| dependencies.md | Reflects updated dependency versions and license information |
| config | Updates subproject commit hash |
| buildSrc/ files | Extensive refactoring of build configuration, dependency management, and quality tooling |
Files not reviewed (1)
- .idea/kotlinc.xml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ScopedLoggingContext.newContext().withLogLevelMap(logLevelMap).execute { | ||
| block() | ||
| } | ||
| ScopedLoggingContext.getInstance() |
There was a problem hiding this comment.
The API change from ScopedLoggingContext.newContext().withLogLevelMap(logLevelMap).execute {} to ScopedLoggingContext.getInstance().newContext().withLogLevelMap(logLevelMap).call {} suggests a breaking change in the logging library. Ensure this change is properly documented and that all calling code has been updated to use the new pattern.
| ScopedLoggingContext.getInstance() | |
| return ScopedLoggingContext.getInstance() |
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-api</artifactId> | ||
| <version>null</version> | ||
| <version>5.13.2</version> |
There was a problem hiding this comment.
JUnit version 5.13.2 is hardcoded in multiple places. Consider using a property or BOM to centralize version management and reduce duplication.
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-engine</artifactId> | ||
| <version>null</version> | ||
| <version>5.13.2</version> |
There was a problem hiding this comment.
JUnit version 5.13.2 is hardcoded in multiple places. Consider using a property or BOM to centralize version management and reduce duplication.
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-params</artifactId> | ||
| <version>5.13.2</version> |
There was a problem hiding this comment.
JUnit version 5.13.2 is hardcoded in multiple places. Consider using a property or BOM to centralize version management and reduce duplication.
| const val version = "5.12.2" | ||
| object JUnit : DependencyWithBom() { | ||
|
|
||
| override val version = "5.13.2" |
There was a problem hiding this comment.
The JUnit Platform version 1.13.2 differs from the Jupiter version 5.13.2. Verify this version mismatch is intentional, as typically JUnit Platform and Jupiter versions should be aligned for compatibility.
| * So when we use JUnit as a platform, this property should be picked up | ||
| * for the dependencies automatically. | ||
| */ | ||
| override val version: String = "1.13.2" |
There was a problem hiding this comment.
The JUnit Platform version 1.13.2 differs from the Jupiter version 5.13.2. Verify this version mismatch is intentional, as typically JUnit Platform and Jupiter versions should be aligned for compatibility.
| override val version: String = "1.13.2" | |
| override val version: String = JUnit.version |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
============================================
+ Coverage 60.67% 60.88% +0.20%
Complexity 113 113
============================================
Files 26 26
Lines 562 565 +3
Branches 20 20
============================================
+ Hits 341 344 +3
Misses 213 213
Partials 8 8 🚀 New features to boost your workflow:
|
2 participants
This PR advances local dependencies, addressing recent API changes.
configwas also updated.