Skip to content

feat(prose): update code element styling; cleanup#2174

Merged
dancormier merged 16 commits intobetafrom
SPARK-171/prose-codeblock
Feb 9, 2026
Merged

feat(prose): update code element styling; cleanup#2174
dancormier merged 16 commits intobetafrom
SPARK-171/prose-codeblock

Conversation

@dancormier
Copy link
Contributor

@dancormier dancormier commented Feb 5, 2026

SPARK-171


This PR updates the Prose component to the latest SHINE styles. It also removes xs and md sizes, adds a11y + visual tests, and removes the rounded corners from <code> elements.

Note

This PR does not include a Svelte Prose component since it would really just be <article class="s-prose">{@render children()}</article>.

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: 49bceb1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 49bceb1
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/698a1e8d631df5000813f020
😎 Deploy Preview https://deploy-preview-2174--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 49bceb1
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/698a1e8dc6de8c0008a939df
😎 Deploy Preview https://deploy-preview-2174--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dancormier dancormier marked this pull request as ready for review February 6, 2026 20:28
Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @dancormier. Let's add new: true to the prose item in site-navigation.json. This will show the activity indicator and keep it consistent with the other components we’ve updated. Thanks!

@dancormier dancormier merged commit df11fb5 into beta Feb 9, 2026
14 of 17 checks passed
@dancormier dancormier deleted the SPARK-171/prose-codeblock branch February 9, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants