Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds optional scaling for raw sensor data by introducing a scaled flag and propagation of sensitivity settings through parsing and input modes.
- Expand
raw_data_msgto acceptscaledandsensitivityparameters and apply actual unit scaling. - Update
TapInputModeandon_raw_datato support thescaledflag and forward sensitivity. - Add tests, update examples, README, and history to document and validate the new behavior.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tapsdk/parsers.py | Extended raw_data_msg signature and logic to apply scaling based on sensitivity. |
| tapsdk/inputmodes.py | Added scaled parameter and attribute to TapInputMode. |
| tapsdk/tap.py | Propagate scaled and sensitivity from input mode to parser. |
| tests/test_parsers.py | New test for scaled raw data parsing. |
| tests/test_inputmodes.py | New test for verifying scaled flag in TapInputMode. |
| examples/basic.py | Example updated to enable scaling mode. |
| Readme.md | Documentation on the scaled option added. |
| History.md | Updated known issues section (Windows backend note). |
Comments suppressed due to low confidence (1)
tapsdk/tap.py:182
- [nitpick] The variable name
sensis ambiguous. Rename it tosensitivityfor clarity.
sens = [0, 0, 0]
Contributor
Author
|
solved #28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.