repeatString: Rename test for function genericness#616
Merged
mao-sz merged 1 commit intoTheOdinProject:mainfrom Jan 3, 2026
Merged
repeatString: Rename test for function genericness#616mao-sz merged 1 commit intoTheOdinProject:mainfrom
mao-sz merged 1 commit intoTheOdinProject:mainfrom
Conversation
The test name implies it's testing that repeatString itself can repeat randomly, hence the lengthy clarifying comment. In actuality, the test is to ensure the function is generic. Randomness isn't part of the "test case", only the test case's implementation.
JoshDevHub
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
The test case in question isn't actually for any randomness, that's only part of the implementation to test genericness. Due to the current test name, a lengthy clarifying comment is needed, but I still see students get confused by this and why they don't need to write any randomisation code themselves.
This PR
Issue
N/A
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder