Fix fatal error#1830
Closed
dnicolson wants to merge 3 commits intoTryGhost:masterfrom
dnicolson:patch-1
Closed
Conversation
Collaborator
|
@dnicolson could you perhaps add a test case for this issue? |
Author
I’m not entirely sure. The error only occurs when there’s a slash in the path, so that part might be worth testing. However, I’m not familiar with that section of the code. The fix is only at the C++ level like this, to test this I think you would need to use an additional process to capture the exit signal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1646.
Recreated from #1693 after the branch was changed.