Skip to content

Comments

fix: skip root evals folder files in push and add telemetry error logging#1356

Merged
AAgnihotry merged 3 commits intomainfrom
fix/tooBig
Feb 21, 2026
Merged

fix: skip root evals folder files in push and add telemetry error logging#1356
AAgnihotry merged 3 commits intomainfrom
fix/tooBig

Conversation

@AAgnihotry
Copy link
Contributor

@AAgnihotry AAgnihotry commented Feb 20, 2026

Fixes https://uipath.atlassian.net/browse/SRE-522088

Summary

This PR introduces two key improvements:

  1. Skip files in root evals folder during push: Files directly in the evals/ folder are now skipped during uipath push, while subdirectories like evals/eval-sets/ and evals/evaluators/ are still included and pushed normally.

  2. Add telemetry error logging: Telemetry failures now log warning messages instead of failing silently, making it easier to diagnose why telemetry events might be missing.

Changes

1. Root evals folder file skipping (src/uipath/_cli/_utils/_project_files.py)

  • Modified files_to_include() to return both included files and skipped files
  • Added logic to detect when traversing the root evals/ folder
  • Files directly in evals/ are skipped, but subdirectories are processed normally

2. Push handler updates (src/uipath/_cli/_push/sw_file_handler.py)

  • Updated to handle the new tuple return value from files_to_include()
  • Added logging to print skipped filenames: "Skipping 'evals/file.json' (root evals folder)"
  • Yields UpdateEvent messages with status "skipped" for each skipped file

3. Telemetry error logging (src/uipath/telemetry/_track.py)

  • Added logger.warning() calls for telemetry initialization failures
  • Added logger.warning() calls for event tracking failures
  • Added logger.warning() calls for flush failures
  • All warnings include exception details to aid debugging
  • Added logger.debug() calls with exc_info=True for full stack traces

4. Pack command update (src/uipath/_cli/cli_pack.py)

  • Updated to unpack the new tuple return value from files_to_include()

Testing

  • ✅ All linting checks passed
  • ✅ All formatting checks passed
  • ✅ Type checking passed (no issues in 86 source files)
  • ✅ Package builds successfully
  • ✅ Verified with calculator sample using editable install

Impact

  • Files in root evals/ folder will no longer be pushed to cloud projects
  • Files in evals/eval-sets/ and evals/evaluators/ continue to be pushed normally
  • Telemetry failures will now be visible in logs as WARNING messages
  • No breaking changes to existing functionality

Version

Bumped version to 2.8.48

@github-actions github-actions bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository labels Feb 20, 2026
Copy link
Contributor

@Chibionos Chibionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments, also add tests for the skipping in the sw_file_handler

_AppInsightsEventClient._client.flush()
except Exception:
pass
except Exception as e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

- Use _logger instead of getLogger(__name__) in telemetry initialization
- Make unpacking named in cli_pack.py (skipped_files instead of _)
- Simplify message and show actual folder path in sw_file_handler.py
@AAgnihotry AAgnihotry merged commit bb02d33 into main Feb 21, 2026
95 checks passed
@AAgnihotry AAgnihotry deleted the fix/tooBig branch February 21, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants