fix: skip root evals folder files in push and add telemetry error logging#1356
Merged
AAgnihotry merged 3 commits intomainfrom Feb 21, 2026
Merged
fix: skip root evals folder files in push and add telemetry error logging#1356AAgnihotry merged 3 commits intomainfrom
AAgnihotry merged 3 commits intomainfrom
Conversation
349edc0 to
a40302a
Compare
Chibionos
previously requested changes
Feb 20, 2026
Contributor
Chibionos
left a comment
There was a problem hiding this comment.
approved with comments, also add tests for the skipping in the sw_file_handler
| _AppInsightsEventClient._client.flush() | ||
| except Exception: | ||
| pass | ||
| except Exception as e: |
Chibionos
reviewed
Feb 20, 2026
a40302a to
9f32755
Compare
- Use _logger instead of getLogger(__name__) in telemetry initialization - Make unpacking named in cli_pack.py (skipped_files instead of _) - Simplify message and show actual folder path in sw_file_handler.py
6822418 to
9705a05
Compare
Chibionos
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://uipath.atlassian.net/browse/SRE-522088
Summary
This PR introduces two key improvements:
Skip files in root evals folder during push: Files directly in the
evals/folder are now skipped duringuipath push, while subdirectories likeevals/eval-sets/andevals/evaluators/are still included and pushed normally.Add telemetry error logging: Telemetry failures now log warning messages instead of failing silently, making it easier to diagnose why telemetry events might be missing.
Changes
1. Root evals folder file skipping (
src/uipath/_cli/_utils/_project_files.py)files_to_include()to return both included files and skipped filesevals/folderevals/are skipped, but subdirectories are processed normally2. Push handler updates (
src/uipath/_cli/_push/sw_file_handler.py)files_to_include()"Skipping 'evals/file.json' (root evals folder)"UpdateEventmessages with status"skipped"for each skipped file3. Telemetry error logging (
src/uipath/telemetry/_track.py)logger.warning()calls for telemetry initialization failureslogger.warning()calls for event tracking failureslogger.warning()calls for flush failureslogger.debug()calls withexc_info=Truefor full stack traces4. Pack command update (
src/uipath/_cli/cli_pack.py)files_to_include()Testing
Impact
evals/folder will no longer be pushed to cloud projectsevals/eval-sets/andevals/evaluators/continue to be pushed normallyVersion
Bumped version to 2.8.48