-
Notifications
You must be signed in to change notification settings - Fork 1
feat: map parent_operation_id from runtime_config #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -207,6 +207,7 @@ def test_from_config_loads_runtime_and_fps_properties(tmp_path: Path) -> None: | |
| "outputFile": "my_output.json", | ||
| "stateFile": "my_state.db", | ||
| "logsFile": "my_logs.log", | ||
| "internalArguments": {"parentOperationId": "operationId-123"}, | ||
| }, | ||
| "fpsProperties": { | ||
| "conversationalService.conversationId": "conv-abc", | ||
|
|
@@ -229,6 +230,9 @@ def test_from_config_loads_runtime_and_fps_properties(tmp_path: Path) -> None: | |
| assert ctx.state_file == "my_state.db" | ||
| assert ctx.logs_file == "my_logs.log" | ||
|
|
||
| # parentOperationId is mapped correctly from internal_arguments | ||
|
||
| assert ctx.parent_operation_id == "operationId-123" | ||
|
|
||
| # fpsProperties mapping | ||
| assert ctx.conversation_id == "conv-abc" | ||
| assert ctx.exchange_id == "ex-def" | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new field
parent_operation_idlacks a description. Other similar fields likeconversation_id,exchange_id, andmessage_idhave Field descriptors with descriptions. Consider adding a Field descriptor with a description to maintain consistency with the codebase conventions. For example:parent_operation_id: str | None = Field(None, description="Parent operation identifier")