Rethrow CancellationException to ensure stop by timeout#1144
Draft
Rethrow CancellationException to ensure stop by timeout#1144
Conversation
Vassiliy-Kudryashov
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
CancellationExceptionas the special case in the catch-all logging exception handler inTestCaseGeneratorto ensurethat it is correctly propagated.
Fixes #1141
Type of Change
How Has This Been Tested?
Automated Testing
No tests should break, no new automatic tests have been added.
Manual Scenario
Test generation for
StringExamplesshould terminate in time.Checklist (remove irrelevant options):
This is the author self-check list