feat: allow creating vmdistributed without vmauth set#1897
Merged
AndrewChubatiuk merged 2 commits intomasterfrom Feb 27, 2026
Merged
feat: allow creating vmdistributed without vmauth set#1897AndrewChubatiuk merged 2 commits intomasterfrom
AndrewChubatiuk merged 2 commits intomasterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| // Use an inline spec to define a VMAuth object in-place or provide a name to reference an existing VMAuth. | ||
| VMAuth VMDistributedAuth `json:"vmauth,omitempty"` | ||
| // +optional | ||
| VMAuth *VMDistributedAuth `json:"vmauth,omitempty"` |
Contributor
There was a problem hiding this comment.
let's add Disabled toggle into VMDistributedAuth struct instead. in a version in master omitted VMAuth section means it should get it's name from CR Name
Users should be able to provide their own LB instead of VMAuth (taking care of proper switching themselves), so VMAuth should be optional for VMDistributed
vrutkovs
force-pushed
the
vmdistributed-novmauth
branch
from
d1d3744 to
e0fce5b
Compare
AndrewChubatiuk
force-pushed
the
vmdistributed-novmauth
branch
from
f1c804e to
72801fe
Compare
AndrewChubatiuk
approved these changes
Feb 27, 2026
Contributor
AndrewChubatiuk
left a comment
AndrewChubatiuk
left a comment
There was a problem hiding this comment.
LGTM! Only changelog entry is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users should be able to provide their own LB instead of VMAuth (taking care of proper switching themselves), so VMAuth should be optional for VMDistributed
Fixes #1826