Merged
Conversation
are consistent in the resulting dataframe when using the pairwise compare manager.
axiomcura
approved these changes
Apr 14, 2025
Member
axiomcura
left a comment
There was a problem hiding this comment.
LGTM. However, I'm wondering if we should add tests to verify that the column ordering remains consistent—especially since similar set() operations are used elsewhere in the code. This could be addressed in a separate issue.
Member
Author
I've thought about this as well. There are two reasons I don't think this should be included as a test:
|
Member
Author
|
Thanks for your help with this issue @axiomcura, merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr attempts to fix a problem mentioned in #19, where the column name prefixes will change in the resulting dataframe when calling the pairwise compare manager. Thanks for agreeing to see if the same problem occurs again with your notebook @axiomcura. Please let me know if this doesn't fix the issue.