Enhance CMSSlider component with improved accessibility features#10
Enhance CMSSlider component with improved accessibility features#10viratatwebflow wants to merge 4 commits intoWebflow-Examples:mainfrom
Conversation
- Added ARIA attributes to the CMSSlider and SlideItem components to improve accessibility for screen readers. - Updated the keyboard navigation logic to ensure a better user experience for keyboard users.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
cms-map/README.md
Outdated
|
|
||
| ## React + TypeScript + Vite | ||
|
|
||
| This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules. |
There was a problem hiding this comment.
Can we tweak the README to align similar to the other examples in the repo (getting it up and running in Webflow, removing boilerplate README details)
| @@ -0,0 +1 @@ | |||
| VITE_MAP_KEY=your_mapbox_api_key_here.example | |||
There was a problem hiding this comment.
Any disclaimers we need to make with this API key on client side?
There was a problem hiding this comment.
This is public key safe to expose on client side. I'll add info folks need to setup the mapbox account
zplata
left a comment
There was a problem hiding this comment.
Lgtm! Let's just make sure README is aligned with others but super excited to get this one in
…up instructions - Revised the README to provide a clearer overview of the CMS Map component, including its integration with Mapbox and Webflow CMS. - Added detailed setup instructions, component properties, and technical implementation notes. - Included a preview screenshot and highlighted key features for better user understanding.
Uh oh!
There was an error while loading. Please reload this page.