Conversation
KirstieJane
left a comment
KirstieJane
left a comment
There was a problem hiding this comment.
Thank you @minnieho1115!! I haven't reviewed the meet 3 people blog post because I'm waiting for @sparkler0323 to do that. (There are quite a few spelling mistakes but it looks great from a quick speed read!)
Bring any questions to our "GitHub fun" meeting tomorrow ✨
There was a problem hiding this comment.
This is composite diagram I made with Internet resources,hence there is no direct web source.
There was a problem hiding this comment.
You can link to the individual pictures you've used.
There was a problem hiding this comment.
Sentences on separate lines.
There was a problem hiding this comment.
Thank you.I will do it.
There was a problem hiding this comment.
Can you save this file name without the !_? Just rename to 4yuanmingyuan5.jpg because it makes the formatting in markdown rather strange to have the _ and the ! in the file name.
There was a problem hiding this comment.
Thank you for reminding me this good habit.
There was a problem hiding this comment.
Add link to Tianzi Jiang webpage?
There was a problem hiding this comment.
Good Idea.Thanks!
| @@ -1,10 +1,10 @@ | |||
| --- | |||
There was a problem hiding this comment.
This is looking great @minnieho1115! Just a few comments and then we should be ok to go.
Please can you rename the file without the !? I think it will confuse some websites to have it in the filename.
There was a problem hiding this comment.
Thank Kirstie for giving me lots of great comments!
|
@sparkler0323 - @minnieho1115 and I are still waiting on your review. @minnieho1115 - you have a merge conflict now. I don't have much time this week so I'm not a super helpful person to fix it with you - but ask in the whitaker lab slack channel and someone will be able to help out no problem! |
sparkler0323
left a comment
sparkler0323
left a comment
There was a problem hiding this comment.
Well done Kirstie, please fix the grammatical mistake before merging.
Co-Authored-By: Kirstie Whitaker <kw401@cam.ac.uk>
Co-Authored-By: Kirstie Whitaker <kw401@cam.ac.uk>
Co-Authored-By: Kirstie Whitaker <kw401@cam.ac.uk>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
Co-Authored-By: Sparkler <ang.li@nlpr.ia.ac.cn>
|
@sparkler0323 |
|
Hi @minnieho1115 - you've resolved @sparkler0323's suggestions without committing the changes. So they don't appear in the blog post! Please can you "unresolve" the suggestions and "commit suggestion" if you agree with them? |
|
Hi @minnieho1115 - I've updated master to fix the broken links - please can you update your branch so that CI passes? |
|
Pinging again - I'd like to get this blog post merged - its been open for 2 months. Let me know if you have any questions about updating the branch @minnieho1115 |
3 participants
No description provided.