-
Notifications
You must be signed in to change notification settings - Fork 121
在MacBook通过 Java -jar 启动应用程序时,Thread.currentThread().getContextClassLo… #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ader() 可能为 null 或系统类加载器,导致找不到资源,需要显示的指定类加载器。
Summary of ChangesHello @shenghui555, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 这个拉取请求通过确保在服务加载过程中使用正确的类加载器,解决了在特定部署场景下资源发现失败的问题。此更改提高了应用程序在不同运行环境下的健壮性和兼容性。 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次变更通过在 ServiceLoader.load 方法中显式指定类加载器,解决了在某些环境(如通过 java -jar 启动)下可能出现的资源加载问题。这是一个很好的健壮性改进,可以避免因线程上下文类加载器不正确而导致的 ServiceLoader 失败。代码修改正确且目标明确,我没有发现其他问题。
|
@shenghui555 Thank you for the PR, would you be able to translate the commit message and PR text to English? Also, I think you need to put "fix: " at the front of the PR title to satisfy the "Conventional Commits" job :-) |
|
Google translation: When launching an application on a MacBook via Java -jar, Thread.currentThread().getContextClassLoader() may return null or the system class loader may not find the resource, requiring explicit specification of the class loader. |
|
@shenghui555 Could you provide more details about your use case because usually it is better to rely on the TCCL than on the current class classloader (especially when the classpath is modular) |
|
After I start the Agent client service through a Shell script, when I invoke the Agent server via the a2a protocol for the first time on the user interface, the static code block of ClientBuilder.java will be executed. The invocation works normally on Windows, but encounters a Classloader issue on a MacBook. |
|
May you share your script so that we can take a look ? |
…ader() 可能为 null 或系统类加载器,导致找不到资源,需要显示的指定类加载器。
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕