chore: update Android API levels in workflow matrix

[ttypic]

drop 19, according to Android studio there is 0% of android 19 users

we'll drop android 19 officially in the next minor release and bump minSdk version

Summary by CodeRabbit

• Chores
  • Updated Android emulator testing matrix to test against API levels 21, 24, 29, and 35 (previously 19, 21, 24, 29).

[coderabbitai]

Walkthrough

The Android emulator API level matrix in the GitHub Actions workflow is updated to support newer Android versions. API level 19 is removed and API level 35 is added, shifting the test matrix from [19, 21, 24, 29] to [21, 24, 29, 35].

Changes

Cohort / File(s)	Summary
Android Emulator Configuration .github/workflows/emulate.yml	Updated the emulator matrix to remove API level 19 and add API level 35, adjusting the supported Android versions for CI testing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops through API lands so new,
Level nineteen bids adieu, adieu!
Thirty-five arrives with modern grace,
Testing runs at a faster pace! 🚀

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating Android API levels in the workflow matrix from [19, 21, 24, 29] to [21, 24, 29, 35].
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch drop-api-19

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sacOO7]

lgtm

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

.github/workflows/emulate.yml (1)

42-42: 🛠️ Refactor suggestion | 🟠 Major

Remove the now-dead API-19 conditional from the script step.

With API 19 removed from the matrix, matrix.android-api-level == 19 is always false. The expression ${{ matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }} permanently evaluates to '', leaving a no-op placeholder in every gradlew invocation.

♻️ Proposed fix

-          script: ./gradlew :android:connectedAndroidTest ${{ matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }} || (adb logcat -d System.out:I && exit 1)
+          script: ./gradlew :android:connectedAndroidTest || (adb logcat -d System.out:I && exit 1)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/emulate.yml at line 42, The script line currently embeds a
dead conditional `${{ matrix.android-api-level == 19 && '-PhttpURLConnection' ||
'' }}` that always evaluates to an empty string; edit the `script` step so the
`./gradlew :android:connectedAndroidTest` invocation no longer includes that
conditional placeholder (remove the `${{ ... }}` segment) and keep the existing
`|| (adb logcat -d System.out:I && exit 1)` fallback intact so the command
simply runs `./gradlew :android:connectedAndroidTest` with the same
error-handling behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/emulate.yml:
- Line 42: The script line currently embeds a dead conditional `${{
matrix.android-api-level == 19 && '-PhttpURLConnection' || '' }}` that always
evaluates to an empty string; edit the `script` step so the `./gradlew
:android:connectedAndroidTest` invocation no longer includes that conditional
placeholder (remove the `${{ ... }}` segment) and keep the existing `|| (adb
logcat -d System.out:I && exit 1)` fallback intact so the command simply runs
`./gradlew :android:connectedAndroidTest` with the same error-handling behavior.