Convolutions in 1d in rust#1007
Convolutions in 1d in rust#1007eengamer2007 wants to merge 17 commits intoalgorithm-archivists:mainfrom
Conversation
Amaras
left a comment
There was a problem hiding this comment.
Hi, thank you for your interest in the AAA.
I've run clippy (with -W clippy::pedantic as well) on your code and put all its suggestions here, as well as some suggestions and questions of mine.
I also don't like the fact that you cast a lot between usize and isize in convolve_linear and convolve_cyclic, but I'm not sure how you could do otherwise without increasing complexity (and it makes pedantic clippy complain a lot)
Co-authored-by: Sammy Plat <sammy@sammyplat.fr>
Co-authored-by: Sammy Plat <sammy@sammyplat.fr>
Not sure why I didn't do it in the first place. Co-authored-by: Sammy Plat <sammy@sammyplat.fr>
Co-authored-by: Sammy Plat <sammy@sammyplat.fr>
Co-authored-by: Sammy Plat <sammy@sammyplat.fr>
Co-authored-by: Sammy Plat <sammy@sammyplat.fr>
Co-authored-by: Sammy Plat <sammy@sammyplat.fr>
|
i saw somewhere that I should add my name to the contributers list since this is my first contribution. Should that be in this pull request? |
|
Yeah, add that to this pr, if you can |
…-> isize to Fn(isize, usize) -> usize
|
Oof, sorry for the delay in the response. So, the main problem with your PR currently is that the line numbers don't track correctly. |
|
sorry for the late fix, school was keeping me busy. |
implemented the convolutions 1d in rust