update "tail daemon log file" to use journalctl#503
Open
rjbs wants to merge 3 commits intoandk:masterfrom
Open
update "tail daemon log file" to use journalctl#503rjbs wants to merge 3 commits intoandk:masterfrom
rjbs wants to merge 3 commits intoandk:masterfrom
Conversation
rjbs
force-pushed
the
tail-logfile-journal
branch
from
617afd5 to
12b3aae
Compare
That is ancient and irrelevant, even in testing.
This means we can stop writing pause.log! Also, this switches from "last n bytes" to "last n lines" and so adjusts the options a bit.
This also removes the thing that was putting text into the PAUSE log, since nothing is going to look at the output.
rjbs
force-pushed
the
tail-logfile-journal
branch
from
12b3aae to
bd87171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means we can stop writing these logs twice.
(Ideally, we can get rid of this option at some point.)