feat(login): add remember me functionality#384
Closed
remicastaing wants to merge 2 commits intoangular-fullstack:masterfrom
remicastaing:remember_me
Closed
feat(login): add remember me functionality#384remicastaing wants to merge 2 commits intoangular-fullstack:masterfrom remicastaing:remember_me
remicastaing wants to merge 2 commits intoangular-fullstack:masterfrom
remicastaing:remember_me
Conversation
- replace ngCookies by ngStorage: ngCookies only supports session cookies / ngStorage supports both local and session storage - add remember me checkbox in login.html and login.jade - pass remember me parameter to auth.service in login.controller - replace $cookieStore by $localStorage and $sessionStorage in app.js/coffee - replace $cookieStore by $localStorage and $sessionStorage in auth.service.js/coffee - add an expire parameter to signToken method in the server side auth.service.js Notes: - $sessionStorage is used when « remember me » is not checked - $localStorage is used when « remember me » is checked - with « remember me » checked, the token will expire after 7 days Closes #259 (partly)
Member
|
You'll need to add ngstorage to the fixtures to get the tests to pass: https://github.com/DaftMonk/generator-angular-fullstack/blob/master/test/fixtures/bower.json |
Contributor
Author
|
I added ngstorage in I don't understand npm test fails: |
Contributor
|
- replace angular-cookies by ngStorage
Contributor
Author
|
Yabadabadooo! Thanks @DaftMonk, @chester1000. It works both locally and on Travis. |
Member
|
I can't check this out locally. It says |
Contributor
Author
|
Sorry, I removed it accidentally from my github repo. |
Contributor
Author
|
Her, a new PR: #415 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cookies; ngStorage supports both local and session storage
app.js/coffee
auth.service.js/coffee
auth.service.js
Notes:
Closes #259 (partly)