Skip to content

refactor(@angular/build): remove Node.js v20 conditional file copying logic #32569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Feb 24, 2026
Merged

refactor(@angular/build): remove Node.js v20 conditional file copying logic #32569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions packages/angular/build/src/builders/application/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ import {
import { Result, ResultKind } from './results';
import { Schema as ApplicationBuilderOptions } from './schema';

const isNodeV22orHigher = Number(process.versions.node.split('.', 1)[0]) >= 22;

export type { ApplicationBuilderOptions };

export async function* buildApplicationInternal(
Expand Down Expand Up @@ -222,17 +220,10 @@ export async function* buildApplication(
await fs.writeFile(fullFilePath, file.contents);
} else {
// Copy file contents
if (isNodeV22orHigher) {
// Use newer `cp` API on Node.js 22+ (minimum v22 for CLI is 22.11)
await fs.cp(file.inputPath, fullFilePath, {
mode: fs.constants.COPYFILE_FICLONE,
preserveTimestamps: true,
});
} else {
// For Node.js 20 use `copyFile` (`cp` is not stable for v20)
// TODO: Remove when Node.js 20 is no longer supported
await fs.copyFile(file.inputPath, fullFilePath, fs.constants.COPYFILE_FICLONE);
}
await fs.cp(file.inputPath, fullFilePath, {
mode: fs.constants.COPYFILE_FICLONE,
preserveTimestamps: true,
});
}
});

Expand Down
4 changes: 1 addition & 3 deletions tests/e2e/tests/build/assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import { updateJsonFile } from '../../utils/project';
import { expectToFail } from '../../utils/utils';
import { getGlobalVariable } from '../../utils/env';

const isNodeV22orHigher = Number(process.versions.node.split('.', 1)[0]) >= 22;

export default async function () {
// Update the atime and mtime of the original file.
// Note: Node.js has different time precision, which may cause mtime-based tests to fail.
Expand All @@ -28,7 +26,7 @@ export default async function () {
await expectToFail(() => expectFileToExist('dist/test-project/browser/.gitkeep'));

// Timestamp preservation only supported with application build system on Node.js v22+
if (isNodeV22orHigher && getGlobalVariable('argv')['esbuild']) {
if (getGlobalVariable('argv')['esbuild']) {
const [originalStats, outputStats] = await Promise.all([
stat('public/favicon.ico'),
stat('dist/test-project/browser/favicon.ico'),
Expand Down