Return nothing if popup is not the desired purpose#42
Open
RomainLanz wants to merge 1 commit intoangularify:masterfrom
RomainLanz:patch-3
Open
Return nothing if popup is not the desired purpose#42RomainLanz wants to merge 1 commit intoangularify:masterfrom RomainLanz:patch-3
RomainLanz wants to merge 1 commit intoangularify:masterfrom
RomainLanz:patch-3
Conversation
Member
|
I never looked at this component before. I agree with you, this directive is full of errors and pretty ugly 😄 $('#element').popup();and use all parameters the library provide: http://semantic-ui.com/modules/popup.html#/usage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There are a lot of errors on this directive, like the use of
eval()and many other little things...can be...
But, the main problem here is that
popupis to generic! I've other package who use this HTML option (data-popup) and without a test to be sure thatpopup_meta_datais not undefined I've got a lot of error in my console.This is just a hack. But I think you need to remove completly this component and use some convention like
asm-popupor whatever (sm-*is used by the real Semantic-UI Angular component).