GH-301: Allow adding a vector at the end of VectorSchemaRoot#1013
Open
axreldable wants to merge 1 commit intoapache:mainfrom
Open
GH-301: Allow adding a vector at the end of VectorSchemaRoot#1013axreldable wants to merge 1 commit intoapache:mainfrom
axreldable wants to merge 1 commit intoapache:mainfrom
Conversation
axreldable
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
I'd say it's an |
lidavidm
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Previously, the precondition
index < fieldVectors.size()rejectedindex == fieldVectors.size(), so appending was impossible. The precondition is nowindex <= fieldVectors.size(), and whenindex == fieldVectors.size()the new vector is appended after all existing vectors.The implementation of
VectorSchemaRoot#addVector()is now aligned with BaseTable#insertVector()The change is backward compatible, as it extends the functionality of the
VectorSchemaRoot#addVector()method.Closes #301.