[AURON #2003] Extract common package configs to workspace Cargo.toml#2004
Open
yew1eb wants to merge 3 commits intoapache:masterfrom
Open
[AURON #2003] Extract common package configs to workspace Cargo.toml#2004yew1eb wants to merge 3 commits intoapache:masterfrom
yew1eb wants to merge 3 commits intoapache:masterfrom
Conversation
Cargo.toml
Outdated
| ] | ||
|
|
||
| [workspace.package] | ||
| version = "0.1.0" |
Contributor
There was a problem hiding this comment.
Should this versioning match our current active Auron version? If not, does it make sense to add a comment here that it doesn't reflect the versioning we have in the pom.xml?
Contributor
Author
There was a problem hiding this comment.
Thanks, will fix and align.
yew1eb
force-pushed
the
AURON_2003
branch
2 times, most recently
from
c693bc9 to
b96f6d3
Compare
ShreyeshArangath
approved these changes
Feb 25, 2026
Contributor
ShreyeshArangath
left a comment
ShreyeshArangath
left a comment
There was a problem hiding this comment.
LGTM, just one question
Cargo.toml
Outdated
| ] | ||
|
|
||
| [workspace.package] | ||
| version = "7.0.0-incubating" |
Contributor
There was a problem hiding this comment.
Q: Is there any way to derive this from the pom.xml
| [[package]] | ||
| name = "auron" | ||
| version = "0.1.0" | ||
| version = "7.0.0-incubating" |
Contributor
There was a problem hiding this comment.
The cargo lock does not reflect 8.0.0 as the version, might need to be regenerated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2003
Rationale for this change
What changes are included in this PR?
Move
version, license, editionfrom sub-crates to root workspace.package.Keep
resolverin sub-crates since it does not support workspace inheritance.Are there any user-facing changes?
How was this patch tested?