[AURON #2024] Support multi-JDK versions in Docker images.#2025
Open
slfan1989 wants to merge 1 commit intoapache:masterfrom
Open
[AURON #2024] Support multi-JDK versions in Docker images.#2025slfan1989 wants to merge 1 commit intoapache:masterfrom
slfan1989 wants to merge 1 commit intoapache:masterfrom
Conversation
Signed-off-by: slfan1989 <slfan1989@apache.org>
| # NOTE: JDK 8 and JDK 11 are EOL. Prefer JDK 17+ for new usage. | ||
| # --------------------------------------------------------------------- | ||
| ARG JDK_VERSIONS="8 11 17 21" | ||
| ARG DEFAULT_JDK="8" |
Contributor
There was a problem hiding this comment.
Any reason why the default is still JDK 8?
Comment on lines
+69
to
+86
| ARG DEFAULT_JDK="8" | ||
| ENV JAVA_INSTALL_BASE="/opt/java" | ||
| RUN set -eux; \ | ||
| mkdir -p "${JAVA_INSTALL_BASE}"; \ | ||
| for v in ${JDK_VERSIONS}; do \ | ||
| url="https://github.com/adoptium/temurin${v}-binaries/releases/latest/download/OpenJDK${v}U-jdk_x64_linux_hotspot.tar.gz"; \ | ||
| curl -fsSL "$url" -o /tmp/temurin.tar.gz || { echo "Failed to download JDK ${v}"; exit 1; }; \ | ||
| mkdir -p "${JAVA_INSTALL_BASE}/temurin-${v}"; \ | ||
| tar -xzf /tmp/temurin.tar.gz -C "${JAVA_INSTALL_BASE}/temurin-${v}" --strip-components=1; \ | ||
| done; \ | ||
| rm -f /tmp/temurin.tar.gz; \ | ||
| alt="$(command -v update-alternatives || command -v alternatives)"; \ | ||
| for v in ${JDK_VERSIONS}; do \ | ||
| "$alt" --install /usr/bin/java java "${JAVA_INSTALL_BASE}/temurin-${v}/bin/java" $((100 + v)); \ | ||
| "$alt" --install /usr/bin/javac javac "${JAVA_INSTALL_BASE}/temurin-${v}/bin/javac" $((100 + v)); \ | ||
| done; \ | ||
| "$alt" --set java "${JAVA_INSTALL_BASE}/temurin-${DEFAULT_JDK}/bin/java"; \ | ||
| "$alt" --set javac "${JAVA_INSTALL_BASE}/temurin-${DEFAULT_JDK}/bin/javac" |
Contributor
There was a problem hiding this comment.
This patterns seems like it would bloat the base image quite a bit. Why not, either
- let the callers pass in a build arg like so
- or have different docker files per jdk version (seems like common practice)
| ENV PATH="/root/.cargo/bin:${PATH}" | ||
|
|
||
| # --------------------------------------------------------------------- | ||
| # Install Java (Microsoft OpenJDK 17 - matches Azure Synapse Spark pools) |
Contributor
There was a problem hiding this comment.
We would still want to install Microsoft OpenJDK based java versions for azurelinux, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2024
Rationale for this change
JDK 8 and JDK 11 have reached End of Life (EOL), and our Docker build environments currently use inconsistent JDK versions and installation methods across different Linux distributions. This PR addresses these issues by:
What changes are included in this PR?
Core Changes
Unified multi-JDK support across all 5 Docker build images:
dev/docker-build/ubuntu24/Dockerfiledev/docker-build/debian11/Dockerfiledev/docker-build/centos7/Dockerfiledev/docker-build/rockylinux8/Dockerfiledev/docker-build/azurelinux3/DockerfileAre there any user-facing changes?
None - Default behavior (JDK 8) remains unchanged.
How was this patch tested?
Exists CI.