Open
Conversation
Signed-off-by: Harikrishna Patnala <harikrishna.patnala@gmail.com>
Co-authored-by: Davi Torres <dtorres@simnet.ca> Co-authored-by: dahn <daan.hoogland@gmail.com>
Adds a 4.22.0 to 4.23.0 upgrade path. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
https://github.com/thlorenz/doctoc?tab=readme-ov-file#usage-as-a-git-hook https://github.com/thlorenz/doctoc/releases/tag/v2.2.0 Generates table of contents for Markdown files inside local git repository. Links are compatible with anchors generated by github or other sites. Added TOC to 3 Markdown files. Never have to create a TOC again just run: `pre-commit run doctoc --all-files` - CONTRIBUTING.md - INSTALL.md - README.md So both Apache Airflow and Apache Sedona use `doctoc`: https://github.com/apache/airflow/blob/eb4a8bc03c92d84e8238dcd76becb267ec8c3dd5/.pre-commit-config.yaml#L32 https://github.com/apache/sedona/blob/b0d86fda010e42f30b090aef1b2dbf06aa0a19d2/.pre-commit-config.yaml#L34
Fix and standardize one license header
…mit (#12070) * Add shebang to shell scripts
Co-authored-by: Daan Hoogland <dahn@apache.org>
Co-authored-by: Daan Hoogland <dahn@apache.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the deprecated UCS and Hyper-V hypervisor plugins by removing them from the build configuration and cleaning up related constants and configurations.
Changes:
- Removed UCS and Hyper-V hypervisor plugin modules from the plugins build configuration
- Removed UCS and Hyper-V plugin dependencies from the client module
- Removed UCS-related configuration setting (UCSSyncBladeInterval) from server configuration
- Removed two UCS-related API constants (UCS_DN and UCS_MANAGER_ID)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/pom.xml | Removed hyperv and ucs hypervisor modules from the build |
| client/pom.xml | Removed cloud-plugin-hypervisor-ucs and cloud-plugin-hypervisor-hyperv dependencies |
| server/src/main/java/com/cloud/configuration/Config.java | Removed UCSSyncBladeInterval configuration enum entry |
| api/src/main/java/org/apache/cloudstack/api/ApiConstants.java | Removed UCS_DN and UCS_MANAGER_ID constants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16502 |
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
* 4.22: fix install path for systemvm templates when introducing new sec storage (#11605) fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… (#12032) Fix snapshot physical size after migration (#12166) ConfigDrive: use file absolute path instead of canonical path to create ISO (#11623) Add log for null templateVO (#12406) snapshot: fix listSnapshots for volume which got delete and whose storage pool got deleted (#12433) Notify user if template upgrade is not required (#12483) Fix: proper permissions for systemvm template registrations on hardened systems (#12098) Allow modification of user vm details if user.vm.readonly.details is empty (#10456) NPE fix while deleting storage pool when pool has detached volumes (#12451)
* 4.22: merge forward error
* fix prometheus metadata and sorted. Adds in TYPE and HELP * fix random linting issue
* api,server,ui: support tags for domains Fixes #11608 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * address copilot comment Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix import Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * Added tags support to listDomains API --------- Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Harikrishna Patnala <harikrishna.patnala@gmail.com>
* Fix typo in finalyzeAccountId * fix tests
…#11979) * Implement SSVM storage network IP to API response and GUI details tab * remove network mention from attribute name * remove network from serialized name * fix parameter name in the UI
* fix template id unmanaged vm * Update == to equals Co-authored-by: dahn <daan.hoogland@gmail.com> --------- Co-authored-by: dahn <daan.hoogland@gmail.com>
DaanHoogland
force-pushed
the
disableDeprecatedPlugins
branch
from
1d3bad0 to
0e42c76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?