HAProxy Configuration: network.loadbalancer.haproxy.idle.timeout

[bradh352]

Description

This PR adds a new configuration parameter of network.loadbalancer.haproxy.idle.timeout which controls the HAProxy timeout server and timeout client configuration parameters under the defaults section.

Fixes #12574

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Embedded unit tests to ensure generated configuration file matches.
• Manual testing

How did you try to break this feature and the system with this change?

It has been observed that this will not update dynamically unless some other load balancer configuration is changed (or the VR is restarted). It is not clear if there is any infrastructure to 'trigger' a push to all existing load balancers to regenerate their configuration since this is global.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.90%. Comparing base (a5b6bc3) to head (d30e056).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/network/HAProxyConfigurator.java	71.42%	1 Missing and 1 partial ⚠️
...oud/network/lb/ElasticLoadBalancerManagerImpl.java	0.00%	2 Missing ⚠️
...a/com/cloud/network/router/CommandSetupHelper.java	0.00%	2 Missing ⚠️
...ork/router/VirtualNetworkApplianceManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12586   +/-   ##
=========================================
  Coverage     17.89%   17.90%           
- Complexity    16092    16094    +2     
=========================================
  Files          5936     5936           
  Lines        532734   532767   +33     
  Branches      65165    65173    +8     
=========================================
+ Hits          95347    95371   +24     
- Misses       426711   426718    +7     
- Partials      10676    10678    +2     

Flag	Coverage Δ
uitests	3.68% <ø> (ø)
unittests	19.00% <61.11%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR adds a new global configuration parameter network.loadbalancer.haproxy.idle.timeout to control HAProxy's timeout client and timeout server directives in the defaults section. The default value is 50000 milliseconds (matching the current hardcoded value), and setting it to 0 removes the timeout directives entirely for infinite timeout. This addresses issue #12574 where the aggressive 50-second timeout was problematic for long-running database connections through load balancers.

Changes:

• Added NETWORK_LB_HAPROXY_IDLE_TIMEOUT configuration key with default value of 50000ms
• Updated LoadBalancerConfigCommand to include idleTimeout parameter
• Modified HAProxyConfigurator to generate timeout directives based on the configuration value
• Added health check validation for the idle timeout configuration
• Updated all LoadBalancerConfigCommand instantiations across VR, internal LB, and elastic LB implementations
• Added comprehensive unit tests for timeout configuration generation

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java	Defines the new configuration key for HAProxy idle timeout
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java	Registers the new configuration key in the configurable keys array
core/src/main/java/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java	Adds idleTimeout field and updates constructor signature
core/src/main/java/com/cloud/network/HAProxyConfigurator.java	Implements logic to set or remove timeout directives based on idleTimeout value
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java	Passes idle timeout value to load balancing data for virtual routers
server/src/main/java/com/cloud/network/router/CommandSetupHelper.java	Updates LoadBalancerConfigCommand instantiation with idle timeout value
plugins/network-elements/internal-loadbalancer/src/main/java/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java	Updates LoadBalancerConfigCommand instantiation for internal load balancers
plugins/network-elements/elastic-loadbalancer/src/main/java/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java	Updates LoadBalancerConfigCommand instantiation for elastic load balancers
systemvm/debian/root/health_checks/haproxy_check.py	Adds health check validation for idle timeout configuration (contains bugs)
core/src/test/java/com/cloud/network/HAProxyConfiguratorTest.java	Adds tests for timeout configuration with 0 and non-zero values
core/src/test/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResourceTest.java	Updates test fixtures with idle timeout parameter
core/src/test/java/com/cloud/agent/resource/virtualnetwork/ConfigHelperTest.java	Updates test fixtures with idle timeout parameter

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16705

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests