Bug/unmanaged ingest exceptions #4539

[DK101010]

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

manually testet

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2491

[shwstppr]

LGTM on code changes.

[DaanHoogland]

@DK101010 can you explain why #1 is on the commits listr for this PR?

[DK101010]

@DaanHoogland I had updated my fork with the apache/cloudstack master over the GitHub Web interface. For this I had to created a pull request in my fork.... mmmh is that wrong ?

[DaanHoogland]

@DaanHoogland I had updated my fork with the apache/cloudstack master over the GitHub Web interface. For this I had to created a pull request in my fork.... mmmh is that wrong ?

It is a red flag to me, but i think we'll squash and merge this anyway, so it won't polute our master branch in the end. don't worry.

[DK101010]

@DaanHoogland I had updated my fork with the apache/cloudstack master over the GitHub Web interface. For this I had to created a pull request in my fork.... mmmh is that wrong ?

It is a red flag to me, but i think we'll squash and merge this anyway, so it won't polute our master branch in the end. don't worry.

@DaanHoogland Hmmm ... but how would be looks like right? Not quite sure what should I change in the future.

[DaanHoogland]

@DaanHoogland I had updated my fork with the apache/cloudstack master over the GitHub Web interface. For this I had to created a pull request in my fork.... mmmh is that wrong ?

It is a red flag to me, but i think we'll squash and merge this anyway, so it won't polute our master branch in the end. don't worry.

@DaanHoogland Hmmm ... but how would be looks like right? Not quite sure what should I change in the future.

I think, you would need to branch of master and then base your code on that, or cherry-pick it on it.
$ git checkout master
$ git pull
$ git checkout -b
$ git cherry-pick

or

$ git checkout master
$ git pull
$ git checkout
$ git rebase -i master

not sure what happened with you but it looks like you merged an ancient commit. I doubt if that would have done anything for you.

[DK101010]

@DaanHoogland I had updated my fork with the apache/cloudstack master over the GitHub Web interface. For this I had to created a pull request in my fork.... mmmh is that wrong ?

It is a red flag to me, but i think we'll squash and merge this anyway, so it won't polute our master branch in the end. don't worry.

@DaanHoogland Hmmm ... but how would be looks like right? Not quite sure what should I change in the future.

I think, you would need to branch of master and then base your code on that, or cherry-pick it on it.
$ git checkout master
$ git pull
$ git checkout -b
$ git cherry-pick

or

$ git checkout master
$ git pull
$ git checkout
$ git rebase -i master

not sure what happened with you but it looks like you merged an ancient commit. I doubt if that would have done anything for you.

Could it be that you work with the apache/cloudstack master without forking?

[DaanHoogland]

not sure what happened with you but it looks like you merged an ancient commit. I doubt if that would have done anything for you.

Could it be that you work with the apache/cloudstack master without forking?

I work with several forks. I have my private that I rarely use and only in free time. my company one, some clients and some conculeagues/friends. 12 in total. mine was forked originaly, but on whatever i work, I start with pulling master from the origin and than proceed with git checkout -b <branchname>. it always does the trick.

[DK101010]

not sure what happened with you but it looks like you merged an ancient commit. I doubt if that would have done anything for you.

Could it be that you work with the apache/cloudstack master without forking?

I work with several forks. I have my private that I rarely use and only in free time. my company one, some clients and some conculeagues/friends. 12 in total. mine was forked originaly, but on whatever i work, I start with pulling master from the origin and than proceed with git checkout -b <branchname>. it always does the trick.

I think I understood. your git remote address pointed to apache/cloudstack and your upstream to your fork correct?

[DaanHoogland]

not sure what happened with you but it looks like you merged an ancient commit. I doubt if that would have done anything for you.

Could it be that you work with the apache/cloudstack master without forking?

I work with several forks. I have my private that I rarely use and only in free time. my company one, some clients and some conculeagues/friends. 12 in total. mine was forked originaly, but on whatever i work, I start with pulling master from the origin and than proceed with git checkout -b <branchname>. it always does the trick.

I think I understood. your git remote address pointed to apache/cloudstack and your upstream to your fork correct?

Well, i think you do but in my words:
for master the upstream alias is origin and points to apache/cloudstack and
for the branch i work in i let the remote be for instance my personal fork.

[davidjumani]

Code LGTM

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3353)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33730 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4540-t3353-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_privategw_static_routes	Failure	237.26	test_privategw_acl.py